Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create SearchNav #717

Merged
merged 6 commits into from
Oct 23, 2023
Merged

create SearchNav #717

merged 6 commits into from
Oct 23, 2023

Conversation

OskiTheCoder
Copy link
Member

@OskiTheCoder OskiTheCoder commented Oct 18, 2023 •
edited
Loading

📝 Changes

  • creates SearchNav component

✅ Checklist

  • Visuals are complete and match Figma
  • Code is complete and in accordance with our style guide
  • Design and theme tokens are audited for any relevant changes
  • Unit tests are written and passing
  • TSDoc is written or updated for any component API surface area
  • Stories in Storybook accompany any relevant component changes
  • Ensure no accessibility violations are reported in Storybook
  • Specs and documentation are up-to-date
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

@stephenjwatkins stephenjwatkins self-requested a review October 19, 2023 15:16
stephenjwatkins
stephenjwatkins reviewed Oct 19, 2023
View reviewed changes
easy-ui-react/src/SearchNav/CTAGroup.tsx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/CTAItem.module.scss Show resolved Hide resolved
easy-ui-react/src/SearchNav/CTAItem.tsx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/CTAItem.module.scss Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/CondensedSearchNav.tsx Show resolved Hide resolved
easy-ui-react/src/SearchNav/SearchNav.mdx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/SearchNav.tsx Show resolved Hide resolved
easy-ui-react/src/SearchNav/Selector.tsx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/SelectorTrigger.tsx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/SelectorTrigger.tsx Show resolved Hide resolved
stephenjwatkins
stephenjwatkins approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@stephenjwatkins stephenjwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. SearchNav is a deceptively complicated component

easy-ui-react/src/SearchNav/CTAGroup.tsx Outdated Show resolved Hide resolved
easy-ui-react/src/SearchNav/LogoGroup.tsx Outdated Show resolved Hide resolved
@OskiTheCoder OskiTheCoder merged commit a20b940 into main Oct 23, 2023
@OskiTheCoder OskiTheCoder deleted the search_nav branch October 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenjwatkins stephenjwatkins stephenjwatkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskiTheCoder @stephenjwatkins