Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: MultiSelect #1561

Merged
merged 9 commits into from
Jan 9, 2025
Merged

spec: MultiSelect #1561

merged 9 commits into from
Jan 9, 2025

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented Jan 8, 2025 •
edited
Loading

📝 Changes

  • Add spec for MultiSelect component
  • Provides ability to select multiple items from a searchable list utilizing PillGroup and ComboBox
image

@stephenjwatkins stephenjwatkins marked this pull request as ready for review January 8, 2025 22:44
ralexmatthews
ralexmatthews approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

OskiTheCoder
OskiTheCoder approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@OskiTheCoder OskiTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@stephenjwatkins stephenjwatkins merged commit f275744 into main Jan 9, 2025
5 checks passed
@stephenjwatkins stephenjwatkins deleted the multi-select-spec branch January 9, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskiTheCoder OskiTheCoder OskiTheCoder approved these changes

@ralexmatthews ralexmatthews ralexmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenjwatkins @ralexmatthews @OskiTheCoder