Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ForgeLayout): fix performance/bg attachment #1551

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix(ForgeLayout): fix performance/bg attachment #1551

merged 2 commits into from
Dec 19, 2024

Conversation

stephenjwatkins
Copy link
Member

📝 Changes

  • Stick background on scroll
  • Try to fix some perf issues

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review December 19, 2024 20:57
@stephenjwatkins stephenjwatkins merged commit 2be5e1c into main Dec 19, 2024
5 checks passed
@stephenjwatkins stephenjwatkins deleted the forge-layout-modifications branch December 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskiTheCoder OskiTheCoder OskiTheCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenjwatkins @OskiTheCoder