-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.6 #174
Merged
Merged
Drop python 3.6 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusse-martin
force-pushed
the
fb-ASIM-5273-drop-py36-qmx
branch
3 times, most recently
from
November 1, 2023 17:38
913fb97
to
6eedfd2
Compare
prusse-martin
force-pushed
the
fb-ASIM-5273-drop-py36-qmx
branch
2 times, most recently
from
November 7, 2023 22:44
e8737cc
to
b3c2aa4
Compare
ASIM-5273
It was pretty slow to solve the environment to add them later. ASIM-5273
ASIM-5273
prusse-martin
force-pushed
the
fb-ASIM-5273-drop-py36-qmx
branch
3 times, most recently
from
November 9, 2023 13:24
b52cbd0
to
824a38f
Compare
prusse-martin
requested review from
nicoddemus,
cauebs,
BeneBr and
ro-oliveira95
November 9, 2023 13:56
prusse-martin
commented
Nov 9, 2023
prusse-martin
commented
Nov 9, 2023
cauebs
approved these changes
Nov 9, 2023
prusse-martin
commented
Nov 9, 2023
Please in other PR's please add a link to task :=). |
BeneBr
approved these changes
Nov 9, 2023
nicoddemus
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
prusse-martin
force-pushed
the
fb-ASIM-5273-drop-py36-qmx
branch
4 times, most recently
from
November 10, 2023 14:31
a5a191e
to
79f136f
Compare
ASIM-5273
By "Switch js tests env" read "get the conda env to resolve without conflicts. ASIM-5273
ASIM-5273
Avoid problems as ``` /usr/share/miniconda/envs/qmxgraph/lib/python3.7/site-packages/more_itertools/more.py:5: in <module> from functools import cached_property, partial, reduce, wraps E ImportError: cannot import name 'cached_property' from 'functools' (/usr/share/miniconda/envs/qmxgraph/lib/python3.7/functools.py) ``` ASIM-5273
prusse-martin
force-pushed
the
fb-ASIM-5273-drop-py36-qmx
branch
from
November 10, 2023 19:11
79f136f
to
fa9d413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASIM-5273