Add units for the mass density derivative with respect to enthalpy #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Aug 10, 2023
CHANGELOG.rst
Outdated
Comment on lines
4
to
5
| * Define the category and quantity type ``density derivative in respect to enthalpy``. | ||
| * Add the default unit ``kg2/m3.J``. |
There was a problem hiding this comment.
Suggested change
| * Define the category and quantity type ``density derivative in respect to enthalpy``. | |
| * Add the default unit ``kg2/m3.J``. | |
| * Define the category and quantity type ``density derivative in respect to enthalpy`` (default unit: ``kg2/m3.J``). |
|
Ahh I see you plan to make the release from this branch (given the branch name), correct? That's fine, just make sure to merge (instead of squash) to preserve the tag on |
caio-ramos
force-pushed
the
release-v1.19.0
branch
from
e0b652d
to
e3ba38c
Compare
Exactly, thanks for the tip. |
nicoddemus
approved these changes
Aug 10, 2023
eniohayashi
approved these changes
Aug 10, 2023
caio-ramos
force-pushed
the
release-v1.19.0
branch
from
e3ba38c
to
2b38bf4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCC-93
This is an intermediate step toward the conclusion of DCC-93. Flash exported from PVTLib now has new outputs regarding derivatives with respect to enthalpy. This PR aims to cover the units of these derivatives including a new category and quantity type.