-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable build with ESMX and introduce export_all #237
Conversation
@mvertens @billsacks I'll tests the PR with CESM and UFS to see it is working fine. Then update you. Do you want me to run all CESM testes? |
@uturuncoglu - it probably will not hurt to run the prealpha tests just to make sure that all configurations are tested. But that might be too much - I'll let @billsacks weigh in. Could you please provide a pointer to the ESMX driver or an example to see how CDEPS is used in conjunction with that. |
@mvertens Sure. I'll run pre-alpha tests. The ESMX documentation can be found in here, https://github.com/esmf-org/esmf/blob/develop/src/addon/ESMX/README.md Specifically for CDEPS, I am using it in nuopc-comp-testing action, https://github.com/esmf-org/nuopc-comp-testing (not updated yet to use new version of ESMX), which allows me to test the component standalone by facing . At this point I am calling this action to test component NoahMP regularly (JTTI project). The current test (DATM+NoahMP) can be found in here, https://github.com/esmf-org/noahmp/blob/feature/nuopc_cap/.github/workflows/datm_noahmp.yaml As an example, you need to build CDEPS using following command,
and then using following
and issuing |
@mvertens @billsacks I run pre alpha tests using
I'll try to run this manually again to see what happens. In the mean time, let me know if you want me to run any other test. I am also plaining to run couple of CDEPS configuration from UFS RTs. I'll you update about it. |
It seems that that particular test giving following error,
My run directory is in |
@uturuncoglu this is a known failure with the version of fms being used in the cesm2 alpha tags. |
@fischer-ncar Thanks. It is good to know. BTW, is there any place that list the known issues and tests that are expected to fail. That would be very helpful for me as a unexperienced CESM user. If not, that kind of resource will be very helpful for the developers. |
I also run CDEPS specific tests with |
Thanks for the invitation to review this @uturuncoglu , but I have too much on my plate to review this over the next week. I'm happy to defer to others, particularly given that you have run CESM prealpha tests and they pass. |
@billsacks sure. No worries. I just need to test with UFS weather model and that will be ready to merge. |
@mvertens @fischer-ncar I also run the couple of UFS Weather Model RTs like |
Description of changes
This PR aims to make couple of modification in the build system to enable build CDEPS along with new ESMF ESMX driver and option to disable FoX library for standalone build (default is OFF). In addition, this PR brings additional namelist option (
export_all
) to data component namelist files (d[atm|ice|lnd|ocn|rof|wav]_in
) to export all the available fields without their connection status. This is especially important for the cases that runs CDEPS outside of the application and run via NUOPC connectors.Specific notes
Contributors other than yourself, if any: N/A
CDEPS Issues Fixed (include github issue):
#172
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): No
Any User Interface Changes (namelist or namelist defaults changes): Yes. We option (
export_all
) is added to component namelist file.Testing performed (e.g. aux_cdeps, CESM prealpha, etc): CESM prealpha
Hashes used for testing: cesm2_3_beta15