cam6_4_037: Implementation of CCPP-ized tropopause_find with compatibility with current CAM

[jimmielin]

Closes #1121.

Companion PRs:

• Implementation of CCPP-ized tropopause_find atmospheric_physics#112
• Implements CCPP-ized tropopause_find CAM-SIMA#293

This brings in atmospheric_physics with CCPP-ized tropopause_find and a compatibility wrapper in the place of old tropopause.F90 preserving old behavior and bit-for-bit reproducibility.

Minor edits to certain subroutine calls to remove redundant specification of primary=TROP_ALG_TWMO, backup=TROP_ALG_CLIMATE, as that is the default configuration and such specification is unnecessary.

[nusbaume]

Great work @jimmielin! I have some suggestions to hopefully cleanup the top-level interfaces in CAM and add some extra sanity checks, but otherwise everything looks good.

[nusbaume]

Everything looks great to me now. Thanks!

[cacraigucar]

Mainly comment changes to make them more "long-term". The comments were appropriate during your development (especially to yourself as you are making the mods). Now that we are getting ready to commit, the comments should be less about what "used to be" and more general comments about what the code is doing.

[cacraigucar]

Thanks for the changes. I have one minor edit for clarity.

As a side note - I typically use a known string "CACNOTE" for things I need to address before my final commit. That way I can leave notes to myself during development, but can remove them before they become permanent.

[jimmielin]

As a side note - I typically use a known string "CACNOTE" for things I need to address before my final commit. That way I can leave notes to myself during development, but can remove them before they become permanent.

Thank you, this is good to know. I leave TODOs here and there but had not thought of flagging comments that could be removed in the final commit as well.

[jimmielin]

All tests passed matching expected pre-existing failures.

The Derecho Intel test for SMS FCSD_HCO did not match baseline at initial attempt and was resubmitted and passed w/o any changes. The test is suspect due to reproducibility issues in HEMCO and may be solved by future GEOS-Chem updates...

➜  aux_run_failing_intel_20240930183121 ./cs.status.aux_run_failing_intel_20240930183121
aux_run_failing_intel_20240930183121: 1 test
  SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h (Overall: PASS) details:
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h CREATE_NEWCASE
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h XML
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SETUP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHAREDLIB_BUILD time=329
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h NLCOMP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MODEL_BUILD time=334
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SUBMIT
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h RUN time=464
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h GENERATE /glade/derecho/scratch/hplin/aux_run_failing_intel_20240930183121/baselines
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_036_intel:
    FAIL SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MEMCOMP [Errno 2] No such file or directory: '/glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_036_intel/SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h/cpl-mem.log'
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h TPUTCOMP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MEMLEAK insufficient data for memleak test
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHORT_TERM_ARCHIVER

[jimmielin]

Baselines (including failed rerun for SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h) archived on Izumi and Derecho