Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project checks from issue-closing script. #1130

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

nusbaume
Copy link
Collaborator

This PR should allow the issue-closing script to work on the cam_development branch like it did previously.

However, it also means that there is currently no multi-branch checking, so the script will need modification (or at least we all will need to be careful) once a new release branch has been created.

Fixes #1119

@nusbaume nusbaume added bug-fix This PR was created to fix a specific bug. Github action Related to Github Actions for this repo. labels Aug 19, 2024
@nusbaume nusbaume self-assigned this Aug 19, 2024
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just requesting tiny comment change.

.github/scripts/branch_pr_issue_closer.py Outdated Show resolved Hide resolved
@nusbaume nusbaume merged commit a08e8c4 into ESCOMP:cam_development Aug 19, 2024
2 checks passed
@nusbaume nusbaume deleted the issue_close_fix branch October 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug. Github action Related to Github Actions for this repo.
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants