-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_021: CCPP'ize dadadj #1026
Conversation
… to redirect this to the tagged version
… name is in Filepath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had a couple of concerns related to the new error message generation.
Externals_CAM.cfg
Outdated
@@ -50,9 +50,9 @@ tag = ALI_ARMS_v1.0.1 | |||
required = True | |||
|
|||
[atmos_phys] | |||
tag = atmos_phys0_02_006 | |||
branch = dadadj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding the usual reminder to point to a tag once ESCOMP/atmospheric_physics#91 has been approved and merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will do. Nice to know the order these things need to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it easier to review this along with the atmospheric_physics PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great now, thanks!
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp cam6_4_021: CCPP'ize dadadj Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation. ESCOMP commit: 782f134
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp cam6_4_021: CCPP'ize dadadj Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation. ESCOMP commit: 782f134
Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation.