Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_021: CCPP'ize dadadj #1026

Merged
merged 16 commits into from
Aug 17, 2024
Merged

Conversation

jtruesdal
Copy link
Collaborator

Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation.

@cacraigucar cacraigucar self-requested a review May 20, 2024 22:58
@cacraigucar cacraigucar requested a review from nusbaume May 28, 2024 16:49
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had a couple of concerns related to the new error message generation.

@@ -50,9 +50,9 @@ tag = ALI_ARMS_v1.0.1
required = True

[atmos_phys]
tag = atmos_phys0_02_006
branch = dadadj
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding the usual reminder to point to a tag once ESCOMP/atmospheric_physics#91 has been approved and merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will do. Nice to know the order these things need to be done.

src/physics/cam/dadadj_cam.F90 Outdated Show resolved Hide resolved
src/physics/cam/dadadj_cam.F90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it easier to review this along with the atmospheric_physics PR.

src/physics/cam/dadadj_cam.F90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great now, thanks!

.gitmodules Outdated Show resolved Hide resolved
@cacraigucar cacraigucar changed the title CCPP'ize dadadj cam6_4_021: CCPP'ize dadadj Aug 14, 2024
@jtruesdal jtruesdal merged commit 782f134 into ESCOMP:cam_development Aug 17, 2024
2 checks passed
cacraigucar added a commit to cacraigucar/CAM that referenced this pull request Aug 19, 2024
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp

cam6_4_021: CCPP'ize dadadj
Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation.

ESCOMP commit: 782f134
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1026 from jtruesdal/dadadj_ccpp

cam6_4_021: CCPP'ize dadadj
Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation.

ESCOMP commit: 782f134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants