feat: export methods getVerificationMethod(..) and isDataAuthentic(...) related to VerifiableURI encoding
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
feat/encoding-features-with-docs
branch
3 times, most recently
from
c76a69f
to
378d833
Compare
CJ42
force-pushed
the
feat/encoding-features-with-docs
branch
3 times, most recently
from
aecb6b2
to
6ebcdd0
Compare
CJ42
changed the title
VerifiableURI encodinggetVerificationMethod(..) and isDataAuthentic(...) related to VerifiableURI encoding
CJ42
force-pushed
the
feat/encoding-features-with-docs
branch
from
5f7afb8
to
335608f
Compare
Hugoo
suggested changes
May 21, 2024
| const result = await getDataFromExternalSources( | ||
| [schema], | ||
| dataFromChain, | ||
| 'https://api.universalprofile.cloud/ipfs/', |
There was a problem hiding this comment.
Please mock this as we can't rely on outside API/server for the testing of this lib.
|
docs updated here: https://github.com/ERC725Alliance/erc725.js/pull/447/files |
Hugoo
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
✨ Feature
What is the current behaviour (you can also link to an open issue here)?
Some methods defined in the lib are only available internally, but exposed to the class or exported in the main index.js of the lib.
What is the new behaviour (if this is a feature change)?
Add the following methods + their relevant docs:
getVerificationMethodisDataAuthentic