This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
updated abieos to the latest eosio-2.1.x branch #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passthrough return of main within start function of tester WASMs.
depricated methods
|
@heifner @huangminghuang please review |
heifner
approved these changes
Jun 24, 2021
| @@ -170,7 +170,7 @@ inline partial_key make_key(T&& t) { | |||
| return partial_key(convert_to_key(std::forward<T>(t))); | |||
| } | |||
| inline partial_key make_key(partial_key&& t) { | |||
| return t; | |||
| return std::move(t); | |||
There was a problem hiding this comment.
As far as understand, you shouldn't use std::move(t) here. You can check https://stackoverflow.com/questions/14856344/when-should-stdmove-be-used-on-a-function-return-value for explanations about when you should (or should not) use return std::move(...);
There was a problem hiding this comment.
I'm not quite sure about the purpose of this function. The old version of it creates a copy of t. So I thought it will make more sense to make it move the content of t.
GCC is complaining about it:
.../key_value.hpp:173:11: warning: local variable 't' will be copied despite being returned by name [-Wreturn-std-move]
return t;
^
.../key_value.hpp:173:11: note: call 'std::move' explicitly to avoid copying
return t;
^
std::move(t)
There was a problem hiding this comment.
I believe move is appropriate here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed usage of
eosio::opaque::unpack()as it was deprecated inabieos.Change Description
API Changes
Documentation Additions