Addressed code review comments

EMCECS · Apr 29, 2024 · 77c084a · 77c084a
1 parent e7ba832
commit 77c084a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/datagrid/DataGrid.stories.tsx b/src/datagrid/DataGrid.stories.tsx
@@ -420,7 +420,7 @@ storiesOf("DataGrid", module)
             />
         </div>
     ))
-    .add("Grid with pagination and pageSizes dropdown", () => (
+    .add("Grid with pagination and custom page size", () => (
         <div style={{width: "80%"}}>
             <DataGrid
                 columns={normalColumns}

diff --git a/src/datagrid/DataGrid.tsx b/src/datagrid/DataGrid.tsx
@@ -664,11 +664,10 @@ export class DataGrid extends React.PureComponent<DataGridProps, DataGridState>
                     if (customPageSizeInt <= maxCustomPageSize) {
                         this.getPage(currentPage, customPageSizeInt);
                     }
-                    //If page size selected by user is greater than maximum limit for custom page size
+                    // If page size selected by user is greater than maximum limit for custom page size
                     else if (customPageSizeInt > maxCustomPageSize && this.customPageSizeRef.current) {
-                        this.customPageSizeRef.current.value =
-                            totalItems < maxCustomPageSize ? totalItems.toString() : maxCustomPageSize.toString();
-                        this.getPage(DEFAULT_CURRENT_PAGE_NUMBER, customPageSizeInt);
+                        const newCustomPageSize = totalItems < maxCustomPageSize ? totalItems : maxCustomPageSize;
+                        this.getPage(DEFAULT_CURRENT_PAGE_NUMBER, newCustomPageSize);
                     }
                 }
             }