Fix macos install #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgreenberg
requested changes
Oct 22, 2024
| do | ||
| sleep 1 | ||
| done | ||
| } | ||
|
|
||
| wait_for_adb_shell() { | ||
| until adb shell true 2> /dev/null | ||
| until $ADB shell true 2> /dev/null |
There was a problem hiding this comment.
it's usually good practice to wrap variables-in-commands in double quotes, otherwise all manner of chaos can happen if a space or * get into the variable. instead of find/replacing all instances of adb with $ADB, might be easier to make a _adb_shell function like i did with _adb_push
| @@ -86,7 +82,7 @@ setup_rayhunter() { | |||
|
|
|||
| test_rayhunter() { | |||
| URL="http://localhost:8080" | |||
| adb forward tcp:8080 tcp:8080 > /dev/null | |||
| $ADB forward tcp:8080 tcp:8080 > /dev/null | |||
There was a problem hiding this comment.
ditto here, double quotes would probably be a good idea
Comment on lines
19
to
23
| let gids = &[ | ||
| Gid::from_raw(3003), // AID_INET | ||
| Gid::from_raw(3004), // AID_NET_RAW | ||
| ]; | ||
| nix::unistd::setgroups(gids).expect("setgroups failed"); |
Co-authored-by: Will Greenberg <[email protected]>
wgreenberg
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.