Use EESSI module in EESSI-install-software.sh #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 16, 2024 09:55
|
Instance
|
|
Instance
|
|
Instance
|
casparvl
changed the title
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
|
Ghehe, is that a polite way of saying you would like a review? ;-) I don't think it will outright affect the use in |
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
…tware-layer into use_module_in_eessi_install
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
… we want to install in the CVMFS prefix
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
… not suitable as a test package
|
Hmm... That's not the artefacts list I expected :D Yes, this script should be reinstalled. But it should at the very least also install the Ah, that explains! Someone already installed my favorite dummy package that I like to try ;-) |
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Unable to download or merge changes between the source branch and the destination branch. |
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software arch:zen2 |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
ocaisa
requested changes
Oct 22, 2024
|
|
||
| # If in dev.eessi.io, allow building on top of softw | ||
| if [[ "${EESSI_CVMFS_REPO}" == /cvmfs/dev.eessi.io ]]; then | ||
| module use /cvmfs/software.eessi.io/versions/$EESSI_VERSION/software/${EESSI_OS_TYPE}/${EESSI_SOFTWARE_SUBDIR_OVERRIDE}/modules/all |
There was a problem hiding this comment.
Would be good to make a comment that explains the expected precedence in MODULEPATH:
/path/to/dev.eessi.io/modules:/path/to/accel/modules:/path/to/software.eessi.io/modules
There was a problem hiding this comment.
I'm not sure you have caught the case though that would define this:
- I want to install in dev.eessi.io
- I want to install for an accelerator (and require accelerator dependencies)
There was a problem hiding this comment.
I wonder is this what we want to support:
/path/to/dev.eessi.io/accel/modules:/path/to/dev.eessi.io/modules:/path/to/software.eessi.io/accel/modules:/path/to/software.eessi.io/modules
There was a problem hiding this comment.
While my pr moved this section of code, I'm pretty sure it was already there, wasn't it? I'm on my phone currently, so can't easily check
There was a problem hiding this comment.
This one is on me, these changes come from #771, see also @boegel's comment about handling accel cases #771 (comment)
In a meeting we talked about fixing this in a separate PR, but if it's better to address this on this PR I can give it a go when I'm back at my desk this week
There was a problem hiding this comment.
I'd be in favour of doing that in a separate PR, if @ocaisa agrees. This PR currently is mostly a reshuffle: some parts that can only be done after EESSI is initialized got moved down until after the EESSI module is loaded. While the pr replaced sourcing the various init scripts with loading the module, it should not modify behaviour in any way. I think it's more clear of we do a big fix like that in a separate PR
Co-authored-by: ocaisa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.