Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for detecting A64FX to archdetect #608

Draft
wants to merge 1 commit into
base: 2023.06-software.eessi.io
Choose a base branch
from
Draft

add support for detecting A64FX to archdetect #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests_archdetect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
- x86_64/amd/zen3/Azure-CentOS7-7V73X
- x86_64/amd/zen4/Azure-Alma8-9V33X
- x86_64/amd/zen4/Shinx-RHEL8-9654
- aarch64/a64fx/Deucalion-Rocky85
- aarch64/neoverse_n1/Azure-Ubuntu20-Altra
- aarch64/neoverse_n1/AWS-awslinux-graviton2
- aarch64/neoverse_v1/AWS-awslinux-graviton3
Expand Down
1 change: 1 addition & 0 deletions init/arch_specs/eessi_arch_arm.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# ARM CPU architecture specifications (see https://gpages.juszkiewicz.com.pl/arm-socs-table/arm-socs.html for guidance)
# Software path in EESSI | Vendor ID | List of defining CPU features
"aarch64/a64fx" "" "asimdhp sve" # Fujitsu A64FX
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this doesn't fully work, because asimdhp is also available for neoverse_v1, which also has features that start with sve (like svei8mm).

The CPU features check should be checking for exact strings though, and not consider svei8mm as a valid match for sve...

"aarch64/neoverse_n1" "ARM" "asimddp" # Ampere Altra
"aarch64/neoverse_n1" "" "asimddp" # AWS Graviton2
"aarch64/neoverse_v1" "ARM" "asimddp svei8mm"
Expand Down
8 changes: 8 additions & 0 deletions tests/archdetect/aarch64/a64fx/Deucalion-Rocky85.cpuinfo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
processor : 0
BogoMIPS : 200.00
Features : fp asimd evtstrm sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm fcma dcpop sve
CPU implementer : 0x46
CPU architecture: 8
CPU variant : 0x1
CPU part : 0x001
CPU revision : 0
1 change: 1 addition & 0 deletions tests/archdetect/aarch64/a64fx/Deucalion-Rocky85.output
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
aarch64/a64fx
Loading