Add an ability to display original images #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the change can you update the read me file and add yourself to the contributors? |
The current implementation always displays a variant if an image is variable regardless of setting `show_preview_variant` to `nil`. ``` Field::ActiveStorage.with_options(show_preview_variant: nil) ``` This change allows us to show the original image by passing `false`. ``` Field::ActiveStorage.with_options(show_preview_variant: false) ``` Though the behavioral difference between `nil` and `false` is subtle, it somewhat aligns with the Action View's `layout` method. > https://api.rubyonrails.org/classes/ActionView/Layouts/ClassMethods.html#method-i-layout > - false: There is no layout > - nil: Force default layout behavior with inheritance
shouichi
force-pushed
the
original-images
branch
from
8bcdbae
to
f32050e
Compare
|
Thank you. Updated the README. Could you take a look? |
|
LGTM I'll merge and publish tomorrow 👍🏻 |
|
Thank you! No rush :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation always displays a variant if an image is variable regardless of setting
show_preview_varianttonil.This change allows us to show the original image by passing
false.Though the behavioral difference between
nilandfalseis subtle, it somewhat aligns with the Action View'slayoutmethod.