[Optimizer] properly handle multiple and single options #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techfreaque
force-pushed
the
optimizer_fixes
branch
3 times, most recently
from
561af7f
to
f025be0
Compare
techfreaque
force-pushed
the
optimizer_fixes
branch
from
f025be0
to
f2fa726
Compare
ruidazeng
reviewed
Nov 11, 2024
| ): | ||
| for combineable_value in config_element_values: | ||
| if combineable_value not in parent_values: | ||
| new_parent_values = parent_values + [combineable_value] |
There was a problem hiding this comment.
Would it be better if we have something like this instead?
def _generate_possible_multiple_options_values(
self,
possible_values: list,
config_element_values,
parent_values: Optional[list] = None,
):
if parent_values is None:
parent_values = []
# rest of the code...There was a problem hiding this comment.
Using a mutable default argument like parent_values=[] can lead to unintended side effects because the same list instance is shared across all calls to the function.
There was a problem hiding this comment.
Hi @ruidazeng
ah I see thanks, I changed it
techfreaque
force-pushed
the
optimizer_fixes
branch
2 times, most recently
from
76085a5
to
96ceb59
Compare
techfreaque
force-pushed
the
optimizer_fixes
branch
from
96ceb59
to
bd19596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need to adapt private optimizer code:
for ConfigTypes.MULTIPLE_OPTIONS to work properly (multiple-options user inputs), the strategy design config generated by the frontend needs to pass the config "type": ConfigTypes.MULTIPLE_OPTIONS.value (config_element[self.CONFIG_TYPE] == ConfigTypes.MULTIPLE_OPTIONS.value)
all other ConfigTypes are supported to set via "type" as well, but should not be saved/sent via api as we can infer them still