[Optimizer] fix shuffle runs on runs less than select size #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techfreaque
force-pushed
the
fix_shuffle_runs
branch
2 times, most recently
from
c2eb32b
to
0faafe3
Compare
techfreaque
force-pushed
the
fix_shuffle_runs
branch
2 times, most recently
from
5badecd
to
771bcd8
Compare
techfreaque
force-pushed
the
fix_shuffle_runs
branch
from
771bcd8
to
e775209
Compare
ruidazeng
suggested changes
Nov 11, 2024
| selected_runs = shuffled_runs if select_size is None else shuffled_runs[:select_size] | ||
| selected_runs = (shuffled_runs | ||
| if (select_size is None or select_size <= len(shuffled_runs)) | ||
| else shuffled_runs[:select_size]) |
There was a problem hiding this comment.
The updated shuffle_and_select_runs function introduces a logic error, the if condition selects all runs when select_size is None or less than or equal to the number of runs, which means it ignores the select_size limit in cases where it should apply.
There was a problem hiding this comment.
Hi @ruidazeng
oh I see, I changed it from <= to >=
techfreaque
force-pushed
the
fix_shuffle_runs
branch
from
e775209
to
aab7059
Compare
ruidazeng
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.