Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typingProxy + Add some features #799

Closed
wants to merge 3 commits into from

Conversation

Akinator31
Copy link
Contributor

I fixed an issue with the TypingProxy module that just wasn't working at all. The problem was that the "if" which checks that typingProxy is enabled in the config file, was trying to check that the "channel" parameter was an instance of the Eris PrivateChannel class. However, it always returned False due to a problem in Eris's code.

if (config.typingProxy && (channel instanceof Eris.PrivateChannel) TO if (config.typingProxy && !(channel instanceof Eris.GuildChannel))

To solve this problem, I simply checked that the "channel" was not a server message and it worked.

@Akinator31 Akinator31 mentioned this pull request May 28, 2024
@Akinator31 Akinator31 changed the title Fix typingProxy which did not work Fix typingProxy + Add some features May 28, 2024
@rubyowo
Copy link
Contributor

rubyowo commented May 28, 2024

You should create separate PRs for different features

@Akinator31
Copy link
Contributor Author

Yes but I have to create different fork..

@zayKenyon
Copy link

Yes but I have to create different fork..

No you don't! You need to create different branches. Normally master (or main, but master in this case) is preserved with new branches deriving from that. Realistically, if you want to get this merged, you will make life easy for the maintainers and make separate PRs for different features.

I don't know your exact setup but it looks like you're trying to merge your master. I would suggest making a new branch from your latest commit, stashing the secondary features, and then editing your PR to reflect this. You can use these stashed commits to form their own branches, which should become PRs in their own right.

@Akinator31
Copy link
Contributor Author

Oh yes, you're right, I'll do that. Thanks for the tip ;)

@Akinator31 Akinator31 closed this Jul 5, 2024
@zayKenyon
Copy link

Thank you, the documentation in #806 is great!

@Akinator31
Copy link
Contributor Author

Thank you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants