Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove observing preconditions #231

Conversation

antipovi-draeger
Copy link
Contributor

@antipovi-draeger antipovi-draeger commented Jan 13, 2025

We decided to remove the flawed Observing Preconditions

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Adherence to coding conventions
    • Pull Request Assignee
    • Reviewer
  • Adherence to javadoc conventions
    • Pull Request Assignee
    • Reviewer
  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • config update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • SDCcc executable ran against a test device (if necessary)
    • Pull Request Assignee
    • Reviewer

@antipovi-draeger antipovi-draeger self-assigned this Jan 13, 2025
Copy link
Contributor

@jannast jannast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, remove TestClientMdibAccessObserver and related code.

@antipovi-draeger antipovi-draeger merged commit b41c1f0 into Draegerwerk:main Jan 14, 2025
2 checks passed
@antipovi-draeger antipovi-draeger deleted the remove-observing-preconditions branch January 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants