-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse and build timezone data into stubs #134
Conversation
I need to go through it in more detail, but first impressions are that it looks good. I'm mostly just commenting to let you know that I'm not ignoring this :-) |
Hey, thanks for the heads up. If just implementing for stub-countries then it is probably near completion with a few tweaks needed here or there, I haven't gone down the rabbit hole of trying to return a single timezone for non-stub countries. I'd have to confirm but i think using just Number::Phone you might get a stub country or not so timezones() might return undef for some but not most, which might make it a little confusing if you didn't realise you needed to use ::Lib to always get non-undef. I'd also want to check what happens in the case of international numbers like +800 and what we should do there. |
I think for all the weird international ranges like +800 the only reasonable responses are either |
b41ef0b
to
e20f13e
Compare
Is there anything else left that you plan to do on this? I think it looks like it's ready for release, although I think that at first I'll mark it as being experimental and subject to minor change. |
It should be good to go. At the start we talked about making a function that returned a single "best" timezone, though this would need some work to determine what is "best". I'm not planning to work on that at the moment, but could be a future addition. |
This will be in the next release, which will be some time this weekend |
See #132