fix #926 Select with many entries / Unable to scroll on touch devices

DominoKit · May 5, 2024 · cd52a72 · cd52a72
1 parent 25dbe58
commit cd52a72
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/menu/AbstractMenuItem.java b/domino-ui/src/main/java/org/dominokit/domino/ui/menu/AbstractMenuItem.java
@@ -104,8 +104,6 @@ public AbstractMenuItem() {
     this.addEventListener(
         EventType.touchstart.getName(),
         evt -> {
-          evt.stopPropagation();
-          evt.preventDefault();
           focus();
           openSubMenu();
         });
@@ -148,8 +146,6 @@ public <T extends AbstractMenuItem<V>> T setSelectable(boolean selectable) {
   }
 
   private void onSelected(Event evt) {
-    evt.stopPropagation();
-    evt.preventDefault();
     if (parent.isMultiSelect() && isSelected()) {
       deselect();
     } else {

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/menu/Menu.java b/domino-ui/src/main/java/org/dominokit/domino/ui/menu/Menu.java
@@ -402,6 +402,9 @@ public Menu() {
                 0);
           }
         };
+
+    this.addEventListener(EventType.touchstart.getName(), Event::stopPropagation);
+    this.addEventListener(EventType.touchend.getName(), Event::stopPropagation);
   }
 
   public void focusFirstMatch(String token) {

diff --git a/pom.xml b/pom.xml
@@ -84,7 +84,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <elemental2.version>1.2.1</elemental2.version>
-        <gwt.version>2.10.0</gwt.version>
+        <gwt.version>2.11.0</gwt.version>
         <jackson.apt.version>1.0.4</jackson.apt.version>
         <gwt.i18n.version>1.0.2</gwt.i18n.version>
         <domino.doc.tool.version>1.0.0</domino.doc.tool.version>
-Original file line number
+Diff line change
@@ Expand Up / @@ -402,6 +402,9 @@ public Menu() { @@
 );
               }
             };
+        this.addEventListener(EventType.touchstart.getName(), Event::stopPropagation);
+        this.addEventListener(EventType.touchend.getName(), Event::stopPropagation);
       }
       public void focusFirstMatch(String token) {
@@ Expand Down @@