Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deep equal #319

Closed
wants to merge 1 commit into from
Closed

Remove deep equal #319

wants to merge 1 commit into from

Conversation

arik123
Copy link
Contributor

@arik123 arik123 commented Apr 7, 2021

Removed deep equal, as it is unneccessary - Instead just set variable every time we changed something and check it at the end.
Reason for this is performance - deep-equal is computationaly expensive recursive function, so this decreases resource usage and speeds up event loop.

@DoctorMcKay
Copy link
Owner

Thanks for the contribution. I'm going to decline this, since deep-equal is already removed in v3, which I hope to be releasing shortly. (#295)

@DoctorMcKay DoctorMcKay closed this Apr 7, 2021
@arik123
Copy link
Contributor Author

arik123 commented Apr 8, 2021

I've checked V3 and it does not seem like you removed deep-equal, you just replaced it with yours, but the performance problem is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants