Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit versions of rarfile that can be used #1028

Closed
wants to merge 1 commit into from

Conversation

gene1wood
Copy link

In markokr/rarfile#70 it's reported that the custom_check function was removed from the rarfile pypi package. As a result the error reported in #1013 occurs when a version of rarfile newer than 3.1 is installed.

This fixes #1013 by limiting the range of rarfile versions.

Once the legendastv provider is changed to no longer use custom_check this version constraint could be removed.

In markokr/rarfile#70 it's reported that the `custom_check` function
was removed from the rarfile pypi package. As a result the error
reported in Diaoul#1013 occurs when a version of rarfile
newer than 3.1 is installed.

This fixes Diaoul#1013 by limiting the range of rarfile versions.

Once the legendastv provider is changed to no longer use `custom_check`
this version constraint could be removed.
@gene1wood
Copy link
Author

gene1wood commented Apr 6, 2021

The python 2.7 Jenkins tests are failing because of #1029
I'm unsure why the python 3 Jenkins tests are failing, they report

________________________ ERROR collecting test session _________________________

Direct construction of Pep8Item has been deprecated, please use Pep8Item.from_parent.

See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.

However I don't see any use of from_parent in the subliminal tests

@clach04
Copy link

clach04 commented May 8, 2022

Alternative solution is #1045, however the setup.py in that should be updated to require >3.1

@gene1wood
Copy link
Author

This PR is waiting on someone to begin maintaining this repo (see #1046) as otherwise there's nobody to merge it.

@getzze
Copy link
Collaborator

getzze commented May 9, 2024

legendastv Provider was removed

@getzze getzze closed this May 9, 2024
@gene1wood
Copy link
Author

@getzze Do you know what commit it was removed in? It appears to still be present and using the no longer existing custom_check method, but I could be wrong.

https://github.com/Diaoul/subliminal/blob/f86450918501ef11e26e40eef153654c52a6d8bb/subliminal/providers/legendastv.py

@ptrcnull
Copy link
Collaborator

it was 4130a48, but it's only on the develop branch; you'll have to wait for the new release

@getzze
Copy link
Collaborator

getzze commented May 13, 2024

Exactly, I was trying to close old PRs, sorry for not giving more information. Thanks @ptrcnull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem using legendastv as provider
4 participants