Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arrays of strings to be used with Waveforms #102

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Allow arrays of strings to be used with Waveforms #102

merged 7 commits into from
Apr 4, 2023

Commits on Mar 29, 2023

  1. Allow arrays of strings to be used with Waveforms 

    Note the tests fail, largely due to now numpy defaults to
a floating point dtype, which we cannot coerce into an array of strings.

Also TODOs need completion...
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    7d852a0 View commit details
    Browse the repository at this point in the history

  2. Add support and tests for List[str] 

    Note that these tests don't currently pass!
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f127bf2 View commit details
    Browse the repository at this point in the history

  3. Handle returning a numpy array of strings 

    Also make all the tests pass. Involved skipping
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    01163d2 View commit details
    Browse the repository at this point in the history

  4. Add exception on overlong string setting 

    Also add more tests
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    01308e0 View commit details
    Browse the repository at this point in the history

  5. Return a list of strings regardless of input

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    84346b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Code review changes 

    - Rewrites the note on waveform of strings
- Refactors _require_waveform
- Removes unused DTYPE and add more tests for mixed lists
    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    5b59ed7 View commit details
    Browse the repository at this point in the history

  2. Move CHANGELOG message to correct position

    @AlexanderWells-diamond
    AlexanderWells-diamond committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    65f8bd8 View commit details
    Browse the repository at this point in the history