migrate p38 to i22

[stan-dot]

Fixes #502

Instructions to reviewer on how to test:

1. BEAMLINE=p38 dodal connect i22
2. expect all to connect

Checks for reviewer

• Would the PR title make sense to a scientist on a set of release notes
• If a new device has been added does it follow the standards
• If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
• Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

[stan-dot]

@pytest.fixture(scope="function")
def module_and_devices_for_beamline(request):
    beamline = request.param
    with patch.dict(os.environ, {"BEAMLINE": beamline}, clear=True):
        bl_mod = importlib.import_module("dodal.beamlines." + beamline)
        importlib.reload(bl_mod)
        mock_beamline_module_filepaths(beamline, bl_mod)
        devices, _ = make_all_devices(
            bl_mod,
            include_skipped=True,
            fake_with_ophyd_sim=True,
        )
        yield (bl_mod, devices)
        beamline_utils.clear_devices()
        del bl_mod

the conftest is very opinionated and overriding it 'from the other file' seems impossible,

the quick and easy way to fix is it to use another conftest,

or add some param to the fixture to skip the os environ patch if it's a lab beamline

@DominicOram , @callumforrester please share your perspectives

[DominicOram]

Should: I think BL contains p38 or i22 string can't we use that rather than the if statement here?

[DominicOram]

the conftest is very opinionated and overriding it 'from the other file' seems impossible,

Sorry, I'm not sure I understand. You can override the BEAMLINE env variable by passing in the beamline you want like in @pytest.mark.parametrize("module_and_devices_for_beamline", ["i22"], indirect=True). Or are you trying to override something else?

On a side-note I would be careful about merging this until we have fixed #864 as it could be masking errors.

[callumforrester]

Should: Our current design for beamlines where some equipment may or may not be there is to try to initialise every device, report the failures and move on, so we should always try to connect the linkam.