-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM Fixes for ophyd async types mega merge #858
Draft
rtuck99
wants to merge
12
commits into
mx-bluesky_475_multi_centre_plan
Choose a base branch
from
fixes_for_ophyd_async_mega_merge
base: mx-bluesky_475_multi_centre_plan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DNM Fixes for ophyd async types mega merge #858
rtuck99
wants to merge
12
commits into
mx-bluesky_475_multi_centre_plan
from
fixes_for_ophyd_async_mega_merge
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtuck99
force-pushed
the
mx-bluesky_475_multi_centre_plan
branch
from
October 22, 2024 13:41
65bf6a3
to
303869f
Compare
rtuck99
force-pushed
the
fixes_for_ophyd_async_mega_merge
branch
from
October 23, 2024 15:10
431b950
to
1b5cfd6
Compare
rtuck99
force-pushed
the
fixes_for_ophyd_async_mega_merge
branch
from
October 23, 2024 15:14
1b5cfd6
to
9b8109d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mx-bluesky_475_multi_centre_plan #858 +/- ##
=================================================================
Coverage 95.19% 95.19%
=================================================================
Files 120 120
Lines 4997 4978 -19
=================================================================
- Hits 4757 4739 -18
+ Misses 240 239 -1 ☔ View full report in Codecov by Sentry. |
4 tasks
rtuck99
force-pushed
the
fixes_for_ophyd_async_mega_merge
branch
from
October 25, 2024 12:14
def6e22
to
3732d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breakages in dodal for bluesky/ophyd-async#594
Note this fix depends on #814
TODO
assert_configuration()
in ophyd async not working for numpy arraysPMACStringFoo
devices need to be changed as Signals-inside-signals are no longer permittedFluorescenceDetectorControlState
needs to be either astr
-basedStrictEnum
with appropriate valuesInstructions to reviewer on how to test:
StrictEnum
/SubsetEnum
is appropriateChecks for reviewer
dodal connect ${BEAMLINE}