Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added watsonmarlow323 device for i22 ppump. #575

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Added watsonmarlow323 device for i22 ppump. #575

wants to merge 6 commits into from

Commits on Jul 1, 2024

  1. Added watsonmarlow323 device for i22 ppump.

    @barnettwilliam
    William Barnett authored and barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d75ddf9 View commit details
    Browse the repository at this point in the history

  2. Changes from code review: improved naming, made enabled read/write, a… 

    …nd used ophyd-async assert_reading utility function for tests.
    @barnettwilliam
    barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    78ca479 View commit details
    Browse the repository at this point in the history

  3. Fixed linting errors.

    @barnettwilliam
    barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    48697ab View commit details
    Browse the repository at this point in the history

  4. Changes from code review: added device details to docstring, removed … 

    …skip device, enabled fake_with_ophyd_sim, and don't specify read write pv if they are the same.
    @barnettwilliam
    barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    18d5c70 View commit details
    Browse the repository at this point in the history

  5. Change from code review: added simulated pump to p38.

    @barnettwilliam
    barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    07ccf47 View commit details
    Browse the repository at this point in the history

  6. Change from code review: Removed limits that are now propagted by the… 

    …ir corresponding signal.
    @barnettwilliam
    barnettwilliam committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    84824ca View commit details
    Browse the repository at this point in the history