You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I run dodal connect i22 I get all of the beamline connected suspiciously quickly. It turns out that if I edit one of the PV prefixes in i22.pyto be incorrect then dodal connect i22 will still pass.
Acceptance Criteria
If I deliberately break one of the PV prefixes in i22.py then dodal connect i22 actually fails
The text was updated successfully, but these errors were encountered:
This is different than 850: 850 is that when make_all_devices is called, any exceptions in the device_instantiation way of creating and connected devices are swallowed and do not cause test failures.
This is that make_all_devices doesn't ever call connect on the devices given from a @device_factory after they are made- make_all_devices may catch exceptions in instantiating the device and prevent it being an error, but not in the connect which is what's more useful...
If I run
dodal connect i22
I get all of the beamline connected suspiciously quickly. It turns out that if I edit one of the PV prefixes ini22.py
to be incorrect thendodal connect i22
will still pass.Acceptance Criteria
dodal connect i22
actually failsThe text was updated successfully, but these errors were encountered: