Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dodal connect on i22 is not actually connecting #864

Open
DominicOram opened this issue Oct 24, 2024 · 3 comments · May be fixed by #865
Open

Dodal connect on i22 is not actually connecting #864

DominicOram opened this issue Oct 24, 2024 · 3 comments · May be fixed by #865
Assignees

Comments

@DominicOram
Copy link
Contributor

If I run dodal connect i22 I get all of the beamline connected suspiciously quickly. It turns out that if I edit one of the PV prefixes in i22.pyto be incorrect then dodal connect i22 will still pass.

Acceptance Criteria

  • If I deliberately break one of the PV prefixes in i22.py then dodal connect i22 actually fails
@DominicOram
Copy link
Contributor Author

@callumforrester and @DiamondJoseph am I right that this is different to #850?

@DominicOram DominicOram mentioned this issue Oct 24, 2024
4 tasks
@DiamondJoseph
Copy link
Contributor

DiamondJoseph commented Oct 25, 2024

This is different than 850: 850 is that when make_all_devices is called, any exceptions in the device_instantiation way of creating and connected devices are swallowed and do not cause test failures.
This is that make_all_devices doesn't ever call connect on the devices given from a @device_factory after they are made- make_all_devices may catch exceptions in instantiating the device and prevent it being an error, but not in the connect which is what's more useful...

@callumforrester
Copy link
Contributor

Additional acceptance criteria: If we could have a regression unit test that would be great

@DiamondJoseph DiamondJoseph linked a pull request Oct 25, 2024 that will close this issue
4 tasks
@DiamondJoseph DiamondJoseph self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants