-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes from code review: improved naming, made enabled read/write, a…
…nd used ophyd-async assert_reading utility function for tests.
- Loading branch information
1 parent
1d9c989
commit 417aaa1
Showing
4 changed files
with
57 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
from unittest.mock import ANY | ||
|
||
import pytest | ||
from ophyd_async.core import DeviceCollector, set_mock_value, assert_reading | ||
|
||
from dodal.devices.watsonmarlow323_pump import WatsonMarlow323Pump, WatsonMarlow323PumpDirection, WatsonMarlow323PumpState | ||
|
||
@pytest.fixture | ||
async def watsonmarlow323() -> WatsonMarlow323Pump: | ||
async with DeviceCollector(mock=True): | ||
wm_pump = WatsonMarlow323Pump("DEMO-WMPUMP-01:") | ||
|
||
return wm_pump | ||
|
||
async def test_reading_pump_reads_state_speed_and_direction( watsonmarlow323: WatsonMarlow323Pump): | ||
set_mock_value(watsonmarlow323.state, WatsonMarlow323PumpState.STOPPED) | ||
set_mock_value(watsonmarlow323.speed, 25) | ||
set_mock_value(watsonmarlow323.direction, WatsonMarlow323PumpDirection.CLOCKWISE) | ||
|
||
await assert_reading( | ||
watsonmarlow323, | ||
{ | ||
"wm_pump-state": { | ||
"value": WatsonMarlow323PumpState.STOPPED, | ||
"timestamp": ANY, | ||
"alarm_severity": 0, | ||
}, | ||
"wm_pump-speed": { | ||
"value": 25, | ||
"timestamp": ANY, | ||
"alarm_severity": 0, | ||
}, | ||
"wm_pump-direction": { | ||
"value": WatsonMarlow323PumpDirection.CLOCKWISE, | ||
"timestamp": ANY, | ||
"alarm_severity": 0, | ||
}, | ||
} | ||
) | ||
|