Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format files and add pre-commit #5

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Format files and add pre-commit #5

merged 11 commits into from
Aug 21, 2024

Conversation

Dialpuri
Copy link
Owner

What's Changed

  • Formatted files with ruff and pre-commit
  • Added pre-commit yaml

Converted all strings to use double quotes for consistency in Python files. Added missing newlines at the end of various text and configuration files to adhere to coding standards.
Remove unnecessary newlines and fix formatting inconsistencies across several source files to improve code readability and maintainability. Deleted 'package/get_sources' as it is no longer needed and updated file inclusions in 'MANIFEST.in'.
Correct an error in the file renaming condition within swap_files(). Adjust comments and add missing newlines for better code readability and formatting.
Introduce a pre-commit hook setup to ensure code quality. This configuration includes checks for YAML syntax, end-of-file fixes, removal of trailing whitespace, and automatic code formatting with Ruff.
This change updates the .pre-commit-config.yaml to exclude the tests/test_data directory. This prevents unnecessary checks on test data files during pre-commit runs, improving efficiency.
Added "pre-push" to the default stages for the pre-commit configuration to ensure checks run before pushing changes. Also, corrected a typo in the error message of `glycosylate.py` for better clarity.
Updated the pre-commit configuration file to change the default stage from pre-push to pre-commit. This ensures that checks run earlier in the development workflow, potentially reducing the feedback
This commit adds explicit return type annotations to functions in package/src/sails/interface.py. This improves code readability and type checking, ensuring that the returned values are consistent with the expected types.
The 'Get sources' step has been removed from both 'test.yml' and 'wheels.yml' workflow files. This step was deemed unnecessary as the installation steps that follow are already sufficient for the build process.
@Dialpuri Dialpuri merged commit 0167adc into master Aug 21, 2024
2 checks passed
@Dialpuri Dialpuri deleted the add-ruff-formatting branch September 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant