Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound handling is deficient in 0.9.1 #61

Open
aliciasprig opened this issue Apr 15, 2014 · 3 comments
Open

Sound handling is deficient in 0.9.1 #61

aliciasprig opened this issue Apr 15, 2014 · 3 comments
Labels
0.9.x bug
Milestone
Version 0.9.1

Comments

@aliciasprig
Copy link
Collaborator

During the refactoring for 0.9.1 the sound handling code was removed. New sound handling code was add but it's behaviour and functionality was a big downgrade from 0.8.5.

The sound handling needs to be revisited to make it behave like 0.8.5
@aliciasprig aliciasprig added this to the 0.9.1 milestone Apr 15, 2014
@Dhwty
Copy link
Owner

Dhwty commented Apr 22, 2014

Note to myself as regards sound in 0.9.1, Linux requires libpulse-dev to compile.

Also, settings.ini should probably be adjusted so sound isn't muted by default, because it seems to still require a restart to pick up that change.

@Dhwty
Copy link
Owner

Dhwty commented Jun 13, 2014

Is this fixed in 9bca9b5?

@aliciasprig
Copy link
Collaborator Author

That's part of the fix. The rest of the fix is in dad8bfc . At the moment this fix is complete but awaiting more testing before closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.9.x bug
Projects
None yet
Milestone
Version 0.9.1
Development

No branches or pull requests
2 participants
@Dhwty @aliciasprig