verify SQLite db version requirement in UpdateManager::update()

Dheia · Apr 16, 2024 · f943343 · f943343
1 parent d46c368
commit f943343
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/composer.json b/composer.json
@@ -30,7 +30,7 @@
     },
     "require": {
         "php": "^8.2",
-        "winter/storm": "dev-wip-laravel-11",
+        "winter/storm": "dev-wip-laravel-11 as 1.2",
         "winter/wn-system-module": "dev-wip-laravel-11",
         "winter/wn-backend-module": "dev-wip-laravel-11",
         "winter/wn-cms-module": "dev-wip-laravel-11",

diff --git a/modules/system/classes/UpdateManager.php b/modules/system/classes/UpdateManager.php
@@ -135,6 +135,13 @@ public function bindContainerObjects()
     public function update()
     {
         try {
+            $connection = Schema::getConnection();
+            if ($connection->getDriverName() === 'sqlite') {
+                if (version_compare($connection->getServerVersion(), '3.35', '<')) {
+                    throw new Exception("SQLite version minimum requirement not met (>= 3.35)");
+                }
+            };
+
             $firstUp = !Schema::hasTable($this->getMigrationTableName());
             if ($firstUp) {
                 $this->repository->createRepository();

diff --git a/modules/system/console/WinterInstall.php b/modules/system/console/WinterInstall.php
@@ -377,15 +377,6 @@ protected function setupMigrateDatabase()
     {
         $this->line('Migrating application and plugins...');
 
-        $connection = Schema::getConnection();
-
-        if ($connection->getDriverName() === 'sqlite') {
-            if (version_compare($connection->getServerVersion(), '3.35', '<')) {
-                $this->error("SQLite version minimum requirement not met (>= 3.35)");
-                exit;
-            }
-        };
-
         try {
             Db::purge();