Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a useEffect for suspended data synchronization #988

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

ajwootto
Copy link
Contributor

@ajwootto ajwootto commented Nov 6, 2024

  • switch to using a useEffect for suspended data synchronization in the Next SDK
  • calling any kind of setState during a render will always lead to errors in React, it should only be done in effects or event handlers

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 4:01pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 4:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Nov 7, 2024 4:01pm

@ajwootto ajwootto requested a review from a team November 6, 2024 22:19
@ajwootto ajwootto changed the title use a useEffect for suspended data synchronization chore: use a useEffect for suspended data synchronization Nov 7, 2024
@ajwootto ajwootto changed the title chore: use a useEffect for suspended data synchronization fix: use a useEffect for suspended data synchronization Nov 7, 2024
@ajwootto ajwootto enabled auto-merge (squash) November 7, 2024 15:58
@ajwootto ajwootto force-pushed the fix-suspense-synchronization branch from 3d7c43d to 95a05eb Compare November 7, 2024 15:58
@ajwootto ajwootto merged commit 1b4b138 into main Nov 7, 2024
10 of 11 checks passed
@ajwootto ajwootto deleted the fix-suspense-synchronization branch November 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants