fix: Use populated user when checking if user is anonymous #590
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -216,7 +216,7 @@ export class DevCycleClient< | |||
|
|
|||
| this.eventEmitter.emitInitialized(true) | |||
|
|
|||
| if (initialUser.isAnonymous) { | |||
There was a problem hiding this comment.
i thought it was the intention that the user passed into the SDK needed to either have isAnonymous=true, or have a user id set, otherwise you'd receive an error? That's what the comments on the DevCycleUser interface say anyway
There was a problem hiding this comment.
It looks like that's an old comment that wasn't removed when this change was made. After anonymous user ID caching was implemented, if the user ID isn't passed then it's assumed the user is anonymous
Line 52 in 3ee5528
UofPx has been using the SDK with an empty user object, and as a result of this each initialization clears the ID cache and counts as an MAU
There was a problem hiding this comment.
ok. Can you fix that comment and maybe add a test for this?
laurawarr
force-pushed
the
fix-anon-user-cache
branch
2 times, most recently
from
4c54ae5 to
6181617
Compare
laurawarr
force-pushed
the
fix-anon-user-cache
branch
from
6181617 to
47b1fca
Compare
laurawarr
force-pushed
the
fix-anon-user-cache
branch
from
47b1fca to
e6d62f7
Compare
In this PR there was a change that switched from using the populated user to using the initial user to check if the user is anonymous.
isAnonymouswould only be true on the initial user if the SDK is explicitly called with this property. The populated user will have isAnonymous set to true if a user id is not specified.This would cause the cached anonymous user ID to be cleared on every initialization, resulting in more MAUs than expected.