Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update nx to 16.6.0 #587

Merged
merged 9 commits into from
Nov 1, 2023
Merged

chore(deps): update nx to 16.6.0 #587

merged 9 commits into from
Nov 1, 2023

Conversation

jonathannorris
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 4:52pm
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 4:52pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 4:52pm

This was referenced Oct 24, 2023
Merged
Merged
@jonathannorris Graphite App
Copy link
Member Author

jonathannorris commented Oct 24, 2023 •
edited by ajwootto
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

jonathannorris
jonathannorris commented Oct 24, 2023
View reviewed changes
sdk/react-native-expo/project.json
@@ -45,7 +45,8 @@
"input": ".",
"output": "."
}
]
],
"updateBuildableProjectDepsInPackageJson": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajwootto interesting that the migration added these, will need to test this more later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because it was defaulted to true before, and now it defaults false

Base automatically changed from update-nx-16-5-5 to main October 25, 2023 15:55
@jonathannorris jonathannorris mentioned this pull request Oct 25, 2023
Merged
ajwootto
ajwootto reviewed Oct 26, 2023
View reviewed changes
examples/react/react-native-app/metro-v71.config.js Outdated
@@ -0,0 +1,52 @@
/**
* Old custom configuration for React Native v0.71.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea whats going on here?

also seems like we probably need to check that RN app still works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea will check.

jonathannorris
jonathannorris commented Oct 26, 2023
View reviewed changes
migrations.json
{
"cli": "nx",
"version": "16.6.0-beta.0",
"description": "Update metro.config.js to use the new metro config format",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajwootto looks like its from here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but it seems like now theres two config files or something. Do we need both? Is the migration doing something that keeps things "working" but expects you to do some manual work to migrate to the new config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked into this and basically what the migration is doing is writing a backup of your old metro config while replacing the main one with a newly generated one that doesn't have any of the custom configuration from the previous one ported over. The idea is that you're supposed to manually bring over anything custom from your old config. I did that and deleted the v71 version because it's not actually used

@ajwootto ajwootto merged commit 95ab8bd into main Nov 1, 2023
11 checks passed
@ajwootto ajwootto deleted the update-nx-16-6-0 branch November 1, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwootto ajwootto ajwootto approved these changes

Assignees
No one assigned
Labels
10 min review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathannorris @ajwootto