feat: add option for bootstrapping config in JS SDK #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajwootto
commented
Oct 17, 2023
•
ajwootto
commented
- add bootstrapConfig option to provide initial config to JS SDK
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajwootto
changed the title
suthar26
reviewed
Oct 18, 2023
suthar26
approved these changes
Oct 18, 2023
| @@ -43,6 +43,7 @@ type variableEvaluatedHandler = ( | |||
|
|
|||
| export type DevCycleOptionsWithDeferredInitialization = DevCycleOptions & { | |||
| deferInitialization: true | |||
| bootstrapConfig?: never | |||
There was a problem hiding this comment.
I've never seen never before...
There was a problem hiding this comment.
jonathannorris
approved these changes
Oct 18, 2023
ajwootto
force-pushed
the
DVC-9279-boostrap-config
branch
from
519f669 to
4dd82a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.