Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DVC9059 move core server request logic to new lib #565

Merged
merged 8 commits into from
Oct 24, 2023
Merged

feat: DVC9059 move core server request logic to new lib #565

merged 8 commits into from
Oct 24, 2023

Conversation

jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Sep 26, 2023 •
edited
Loading

  • pull out the common request logic between the JS Cloud Server SDK and NodeJS SDK into its own library.

@vercel
Copy link

vercel bot commented Sep 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-next-js ❌ Failed (Inspect) Oct 24, 2023 8:02pm
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:02pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:02pm

@jonathannorris jonathannorris changed the title feat: remove core server request logic to new lib feat: DVC9059 move core server request logic to new lib Sep 26, 2023
This was referenced Sep 26, 2023
Merged
Merged
@jonathannorris Graphite App
Copy link
Member Author

jonathannorris commented Sep 26, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jonathannorris jonathannorris mentioned this pull request Sep 26, 2023
Merged
@jonathannorris jonathannorris requested review from ajwootto and a team September 26, 2023 21:35
@jonathannorris jonathannorris marked this pull request as ready for review September 26, 2023 21:35
@jonathannorris jonathannorris mentioned this pull request Sep 27, 2023
Draft
@jonathannorris jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from ed1fb2d to d811b17 Compare September 29, 2023 15:55
jonathannorris
jonathannorris commented Sep 29, 2023
View reviewed changes
lib/shared/config-manager/src/request.ts
@@ -19,20 +18,3 @@ export async function getEnvironmentConfig(
requestTimeout,
)
}

async function getWithTimeout(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to common request lib

jonathannorris
jonathannorris commented Sep 29, 2023
View reviewed changes
lib/shared/server-request/src/index.ts Outdated
status: number
}

const exponentialBackoff: RequestInitWithRetry['retryDelay'] = (attempt) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved all common request helper functions here used by various server SDKs.

@jonathannorris jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 82ce91a to d7a37aa Compare October 2, 2023 19:23
@jonathannorris jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from adc5edf to 3ec54d0 Compare October 24, 2023 17:51
@jonathannorris jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 3ec54d0 to d2cf865 Compare October 24, 2023 19:12
Base automatically changed from DVC-9059-add-bundled-libraries to main October 24, 2023 19:55
@jonathannorris jonathannorris merged commit 840adb3 into main Oct 24, 2023
11 checks passed
@jonathannorris jonathannorris deleted the DVC-9059-request-lib branch October 24, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwootto ajwootto ajwootto approved these changes

Assignees
No one assigned
Labels
10 min review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathannorris @ajwootto