feat: React Native SSE Support #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ajwootto
reviewed
Dec 12, 2024
ajwootto
reviewed
Dec 12, 2024
ajwootto
reviewed
Dec 12, 2024
suthar26
reviewed
Dec 13, 2024
| "@react-native-async-storage/async-storage": "^1.17.11", | ||
| "react-native-device-info": "^8.7.0", | ||
| "react-native-get-random-values": "^1.7.2" | ||
| "react-native-get-random-values": "^1.7.2", | ||
| "react-native-sse": "^1.2.1" |
There was a problem hiding this comment.
note: this will require docs update as we need to install the other packages separately
There was a problem hiding this comment.
Why wouldn't it be installed from the dependency? seems to work in the E2E test app.
There was a problem hiding this comment.
im not 100 percent sure, but we have that explicit in the docs and in the past when i have tried to install, required me to add those dependencies have not tested recently tbh
suthar26
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SSE connections to the React-Native SDK to enable live-updates of configs.
react-native-sselibraryreact-native-sseEvent Source class from react native libNote: will need to mention in the docs the limitations on react native <0.75 requiring flipper to be disabled: binaryminds/react-native-sse#61