Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resolved server data in non-streaming mode #1006

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ajwootto
Copy link
Contributor

@ajwootto ajwootto commented Dec 3, 2024

  • instead of calling "use" on the server data promise, just use the serverData we already have available on this code path
  • use seems to have some weird edge cases that are probably bugs in Next/React

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 7:59pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 7:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Dec 3, 2024 7:59pm

@ajwootto ajwootto changed the title use resolved server data in non-streaming mode fix: use resolved server data in non-streaming mode Dec 3, 2024
@ajwootto ajwootto requested a review from a team December 3, 2024 20:00
@ajwootto ajwootto merged commit 3ce09e5 into main Dec 3, 2024
12 of 13 checks passed
@ajwootto ajwootto deleted the use-resolved-server-data branch December 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants