fix: cleanup getEnvironmentConfig from nodejs, move tests

DevCycleHQ · Sep 26, 2023 · 51b013c · 51b013c
1 parent d7cd6d5
commit 51b013c
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 23 deletions.
diff --git a/sdk/nodejs/__mocks__/cross-fetch.ts → ...d/config-manager/__mocks__/cross-fetch.ts b/sdk/nodejs/__mocks__/cross-fetch.ts → ...d/config-manager/__mocks__/cross-fetch.ts
diff --git a/sdk/nodejs/__mocks__/fetch-retry.ts → ...d/config-manager/__mocks__/fetch-retry.ts b/sdk/nodejs/__mocks__/fetch-retry.ts → ...d/config-manager/__mocks__/fetch-retry.ts
diff --git a/sdk/nodejs/__tests__/request.spec.ts → .../config-manager/__tests__/request.spec.ts b/sdk/nodejs/__tests__/request.spec.ts → .../config-manager/__tests__/request.spec.ts
@@ -3,12 +3,9 @@ import fetch, { Response } from 'cross-fetch'
 
 global.fetch = fetch
 
+import { getEnvironmentConfig } from '../src/request'
 const fetchRequestMock = fetch as jest.MockedFn<typeof fetch>
 
-import { publishEvents, getEnvironmentConfig } from '../src/request'
-import { dvcDefaultLogger } from '@devcycle/js-cloud-server-sdk'
-const logger = dvcDefaultLogger()
-
 describe('request.ts Unit Tests', () => {
     beforeEach(() => {
         fetchRequestMock.mockReset()

diff --git a/sdk/nodejs/src/request.ts b/sdk/nodejs/src/request.ts
@@ -6,25 +6,6 @@ export const HOST = '.devcycle.com'
 export const EVENT_URL = 'https://events'
 export const EVENTS_PATH = '/v1/events/batch'
 
-export async function getEnvironmentConfig(
-    url: string,
-    requestTimeout: number,
-    etag?: string,
-): Promise<Response> {
-    const headers: Record<string, string> = etag
-        ? { 'If-None-Match': etag }
-        : {}
-
-    return await getWithTimeout(
-        url,
-        {
-            headers: headers,
-            retries: 1,
-        },
-        requestTimeout,
-    )
-}
-
 export async function publishEvents(
     logger: DVCLogger,
     sdkKey: string,