Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pull request flake reference #384

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

dudeofawesome
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for zero-to-nix ready!

Name Link
🔨 Latest commit 449e88b
🔍 Latest deploy log https://app.netlify.com/sites/zero-to-nix/deploys/674f432f44f6bb00084fc2c2
😎 Deploy Preview https://deploy-preview-384--zero-to-nix.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucperkins
Copy link
Member

Although it would be nice for that to be a valid flake reference, unfortunately it is not, and so I will need to politely decline this change

@lucperkins lucperkins closed this Dec 3, 2024
@lucperkins lucperkins reopened this Dec 3, 2024
@lucperkins
Copy link
Member

Okay, never mind, turns out that PR references can be valid, it just turns out that that specific one isn't. My bad 😄

@lucperkins lucperkins enabled auto-merge December 3, 2024 17:43
@lucperkins
Copy link
Member

@dudeofawesome I've updated with a valid PR number and so this is good to go

@dudeofawesome
Copy link
Contributor Author

Haha, was gonna say, I'm using that style right now 😛
Awesome!

@lucperkins lucperkins merged commit f118743 into DeterminateSystems:main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants