Migrate site to Astro #346
Conversation
✅ Deploy Preview for zero-to-nix ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The feedback widget needs a bit of touch-ups: old:
new:
Note this is a problem on both sites, and I'm not real fussed, but I noticed it expands when typing:
...and with a narrower viewport, it gets a bit weirder:
|
src/components/CookieConsent.tsx
Outdated
| import { posthog } from "posthog-js"; | ||
| import { useEffect, useState } from "react"; | ||
|
|
||
| const CookieConsent = () => { |
There was a problem hiding this comment.
I'm not seeing the cookie consent banner show up, but I am seeing event data going to PostHog.
Co-authored-by: Graham Christensen <[email protected]>
|
This is looking good to me. I'm still not seeing the cookie consent popup, but beyond that, I don't see any obvious problems. I think we should move forward with a merge as soon as the consent window comes up. |
|
I cannot for the life of me get it to work, so this will probably be a while |
|
Have you poked around this repo? https://github.com/jop-software/astro-cookieconsent/blob/main/src/main.ts ...poking around a bit I noticed a weird flash of content on every refresh, which turns out to be all the user-initiated things:
...maybe that's a clue? |
|
@grahamc There isn't really a way out of the flash of unstyled content with dark mode and a fully static site. Vue + iles has some JS magic built into it that prevents that but we don't have access to that here. As for the cookie consent plugin, I don't see a way to integrate that with Posthog. |
|
@lucperkins I think if you pin posthog to just before v1.136.0 our posthog conditions will work correctly. |
|
@grahamc Alas, that doesn't work either. I just cannot get |
|
@lucperkins I think it is because posthog is getting its .js from us.i.posthog.com, instead of the bundled version we've pinned. Is that possible? |
The iles framework has essentially been abandoned so it's time to re-platform.
TODOs:
:rocket:)