Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change flake refs and update flake.lock(s) #291

Merged
merged 1 commit into from
Sep 20, 2023
Merged

change flake refs and update flake.lock(s) #291

merged 1 commit into from
Sep 20, 2023

Conversation

Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Sep 17, 2023

All the lockfiles of the templates were from late 2022
the nixpkgs flake refs were using the master branch and had a comment recommending using the flake registry
updated all instances of nodejs-18_x to nodejs_18

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zero-to-nix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 3:41am

@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for zero-to-nix ready!

Name Link
🔨 Latest commit 98d65eb
🔍 Latest deploy log https://app.netlify.com/sites/zero-to-nix/deploys/6506756bd40fb2000877a15e
😎 Deploy Preview https://deploy-preview-291--zero-to-nix.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gerg-L
Copy link
Contributor Author

Gerg-L commented Sep 17, 2023

I don't know why there is locks on any of the template flakes at al...

@lucperkins
Copy link
Member

lucperkins commented Sep 20, 2023

@Gerg-L In general, I like having flake.locks in the template because it eliminates one potential source of breakage. I want people to be able to nix init -t and get to work without worrying that upstream flakes will introduce breaking changes. In fact, one of the reasons we created FlakeHub and are nudging the community toward SemVer is precisely to make things like this less of an update-and-cross-your-fingers scenario.

But I clearly haven't been all that vigilant about updating these, so I appreciate the help 😄 I'll see if maybe there's a way to automate this in the future. For now, LGTM.

@Gerg-L Gerg-L temporarily deployed to test September 20, 2023 09:50 — with GitHub Actions Inactive
@lucperkins lucperkins merged commit acb3099 into DeterminateSystems:main Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants