Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funny joke to shell hook example #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3Rafal
Copy link

@3Rafal 3Rafal commented Feb 3, 2023

Hello,
In Guide 4 I was ordered to:

Run this to see an example shell hook:
nix develop "github:DeterminateSystems/zero-to-nix#hook"
Nix development environments support environment variables as well. Run echo $FUNNY_JOKE to access a (hilarious) value that's available only in the Nix environment.

The problem is that only #example shell sets this variable and it doesn't work in #hook shell.
This PR makes above example work.

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
zero-to-nix ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 3:18AM (UTC)

@lucperkins
Copy link
Member

lucperkins commented Feb 3, 2023

@3Rafal I'm gonna think on this a bit. I think that the proper solution here may be to restructure that doc. I basically inserted some new content about shell hooks in a way that didn't fit with the rest of the narrative. Mea culpa! If I end up closing this, please know that it wouldn't be because I think this is "wrong" in any way 😄

@3Rafal
Copy link
Author

3Rafal commented Feb 3, 2023

@lucperkins , no worries! I had fun tinkering with this project, so even if it's not merged I still learned a lot. Thanks for your effort! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants