Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid length limit for input fasta ids #30

Open
alpae opened this issue Jul 24, 2024 · 1 comment
Open

Avoid length limit for input fasta ids #30

alpae opened this issue Jul 24, 2024 · 1 comment

Comments

@alpae
Copy link
Member

alpae commented Jul 24, 2024

The enforced length limit on the fasta IDs is annoying.

if len(prot_rec_id)>60: # todo 85 is the limit without considering ||s.

we could replace all the IDs with a lookup table. however, there are a few things to consider:

  • doing it before OMAmer mapping means the results cannot easily be reused / existing omamer placements are invalid.
  • debugging will involve an extra (mental) mapping step.
  • generally requires all reporting steps to replace the mapping again.

One option could be to store the mapping in a sqlite database. comments wellcome.

@alpae
Copy link
Member Author

alpae commented Jul 26, 2024

actually, if the problem is only coming from FastTree, we could also extend the FastTree-Wrapper to include a label transformation on the fly. or are there other places with limits? Mafft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant