Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typescript Types #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Typescript Types #31

wants to merge 1 commit into from

Conversation

BendaCoding
Copy link

  • add ts types
  • add rollup ts plugin to build with types

@BendaCoding BendaCoding mentioned this pull request Dec 13, 2019
Open
Jazzepi
Jazzepi reviewed Jan 16, 2020
View reviewed changes
types/shards-react.d.ts
/**
* Whether it is sticky, or not.
*/
sticky?: string;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to be careful this thing isn't a boolean. Look at the source code and the way it's actually used. The fact that it's a string is crazy.

Sticky's only possible value is null/undefined or https://getbootstrap.com/docs/4.0/utilities/position/ the string 'top' because of how it gets used here. https://github.com/DesignRevision/shards-react/blob/master/components/navbar/Navbar.js#L38

JeanOUINA added a commit to JeanOUINA/shards-react that referenced this pull request May 1, 2021
@JeanOUINA
Fix all the outdated shit + apply PRs
42c73b9 
DesignRevision#31
DesignRevision#32
DesignRevision#34
@jakeisnt
Copy link

jakeisnt commented Feb 2, 2022

Hey! Would love to see this merged if possible to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jazzepi Jazzepi Jazzepi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BendaCoding @jakeisnt @Jazzepi