fix path deprecation warning #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #244 |
|
Great, thanks! The build step is expected to fail (bit annoying -- I'll open an issue). The failure on py312 is a weird matplotlib tcl thing which I see every so often. I'll try re-running it now. |
|
Seems like the build is failing on a permission error, so I don't think that's something I can do anything about. Could you have another look? (or let me know next steps for me if there are any) |
|
Right, sorry for the delay. I reran it for the py312 failure, which looks okay now, but didn't get to merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of path as a context manager is deprecated and leads to a warning. In this case, just assigning the variable directly, solves the problem.