Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #210 fix bug in Ugrid1D.merge_partitions #215

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Issue #210 fix bug in Ugrid1D.merge_partitions #215

merged 5 commits into from
Feb 9, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

Fixes #210

This PR:

  • Pass indexes as argument
  • Add extra tests for merging 1D parts and 1D2D parts.

@JoerivanEngelen JoerivanEngelen self-assigned this Feb 9, 2024
Huite
Huite approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@Huite Huite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Huite Huite merged commit 9f65768 into main Feb 9, 2024
5 checks passed
@Huite Huite deleted the issue_210_merge_Ugrid1D branch February 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huite Huite Huite approved these changes

Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ugrid1D.merge_partitions throws error if dataset contains attrs
2 participants
@JoerivanEngelen @Huite