Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated meshkernel apicalls to meshkernel v3 #171

Merged
merged 9 commits into from
Nov 17, 2023
Merged

updated meshkernel apicalls to meshkernel v3 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38d56f5
updated meshkernel is_geometric to projection
veenstrajelmer Oct 27, 2023
10500f3
updated is_geographic to projection in tests init
veenstrajelmer Oct 27, 2023
e8e5b35
fixed linting
veenstrajelmer Oct 27, 2023
97fdcbe
undo
veenstrajelmer Oct 27, 2023
3bc3e34
fixed import
veenstrajelmer Oct 27, 2023
e378cf7
linting
veenstrajelmer Oct 27, 2023
ac19971
removed optional argument from meshkernel availability check
veenstrajelmer Nov 2, 2023
5fbe3bd
Merge branch 'main' into 169-update-meshkernel-api-calls-after-new-re…
JoerivanEngelen Nov 17, 2023
e0610c3
removed projection argument, default is cartesian anyway
veenstrajelmer Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ all = [
'geopandas',
'mapbox_earcut',
'matplotlib',
'meshkernel',
'meshkernel >= 3.0.0',
'netcdf4',
'pooch',
'shapely >= 2.0',
Expand Down
2 changes: 1 addition & 1 deletion xugrid/ugrid/ugrid1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def meshkernel(self) -> "mk.MeshKernel": # type: ignore # noqa
import meshkernel as mk

if self._meshkernel is None:
self._meshkernel = mk.MeshKernel(is_geographic=False)
self._meshkernel = mk.MeshKernel()
self._meshkernel.mesh1d_set(self.mesh)
return self._meshkernel

Expand Down
2 changes: 1 addition & 1 deletion xugrid/ugrid/ugrid2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def meshkernel(self) -> "mk.MeshKernel": # type: ignore # noqa
import meshkernel as mk

if self._meshkernel is None:
self._meshkernel = mk.MeshKernel(is_geographic=False)
self._meshkernel = mk.MeshKernel()
self._meshkernel.mesh2d_set(self.mesh)
return self._meshkernel

Expand Down
Loading